Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deleted reviews in ActivityFeed #1283

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Handle deleted reviews in ActivityFeed #1283

merged 2 commits into from
Apr 9, 2020

Conversation

sktoiva
Copy link
Contributor

@sktoiva sktoiva commented Apr 3, 2020 •
edited
Loading

Handles deleted reviews in transaction activity feed:

image

OtterleyW
OtterleyW approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@OtterleyW OtterleyW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Did you check that everything works as expected on ListingPage and ProfilePage too?

@OtterleyW OtterleyW merged commit 5f3d4fc into master Apr 9, 2020
@Gnito Gnito deleted the handle-deleted-reviews branch May 14, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtterleyW OtterleyW OtterleyW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sktoiva @OtterleyW